Re: [libvirt] [PATCH] Forbid use of ':' in RBD pool names

2013-05-14 Thread Daniel P. Berrange
On Wed, May 15, 2013 at 01:26:03AM +0800, Osier Yang wrote: > On 13/05/13 21:18, Daniel Veillard wrote: > >On Mon, May 13, 2013 at 02:00:31PM +0100, Daniel P. Berrange wrote: > >>From: "Daniel P. Berrange" > >> > >>The QEMU command line syntax for RBD disks is > >> > >>file=rbd:pool/image:opt1

Re: [libvirt] [PATCH] Forbid use of ':' in RBD pool names

2013-05-14 Thread Osier Yang
On 13/05/13 21:18, Daniel Veillard wrote: On Mon, May 13, 2013 at 02:00:31PM +0100, Daniel P. Berrange wrote: From: "Daniel P. Berrange" The QEMU command line syntax for RBD disks is file=rbd:pool/image:opt1=val1:opt2=val2... There is no way to escape the ':' if it appears in the pool or

Re: [libvirt] [PATCH] Forbid use of ':' in RBD pool names

2013-05-13 Thread Daniel Veillard
On Mon, May 13, 2013 at 02:00:31PM +0100, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > The QEMU command line syntax for RBD disks is > >file=rbd:pool/image:opt1=val1:opt2=val2... > > There is no way to escape the ':' if it appears in the > pool or image name. Thus it must be e

[libvirt] [PATCH] Forbid use of ':' in RBD pool names

2013-05-13 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The QEMU command line syntax for RBD disks is file=rbd:pool/image:opt1=val1:opt2=val2... There is no way to escape the ':' if it appears in the pool or image name. Thus it must be explicitly forbidden if it occurs in the libvirt XML. People are known to be abusing