Re: [libvirt] [PATCH] Handle copying bitmaps to larger data buffers

2019-04-25 Thread Cole Robinson
On 4/25/19 5:42 AM, Pavel Hrdina wrote: > On Mon, Apr 15, 2019 at 02:43:07PM +, Allen, John wrote: >> If a bitmap of a shorter length than the data buffer is passed to >> virBitmapToDataBuf, it will read off the end of the bitmap and copy junk >> into the returned buffer. Add a check to only

Re: [libvirt] [PATCH] Handle copying bitmaps to larger data buffers

2019-04-25 Thread Pavel Hrdina
On Mon, Apr 15, 2019 at 02:43:07PM +, Allen, John wrote: > If a bitmap of a shorter length than the data buffer is passed to > virBitmapToDataBuf, it will read off the end of the bitmap and copy junk > into the returned buffer. Add a check to only copy the length of the > bitmap to the buffer.

Re: [libvirt] [PATCH] Handle copying bitmaps to larger data buffers

2019-04-24 Thread Allen, John
Gentle reminder. Any comments on this patch? Thanks, John On Mon, Apr 15, 2019 at 09:43:07AM -0500, Allen, John wrote: > If a bitmap of a shorter length than the data buffer is passed to > virBitmapToDataBuf, it will read off the end of the bitmap and copy junk > into the returned buffer. Add a

[libvirt] [PATCH] Handle copying bitmaps to larger data buffers

2019-04-15 Thread Allen, John
If a bitmap of a shorter length than the data buffer is passed to virBitmapToDataBuf, it will read off the end of the bitmap and copy junk into the returned buffer. Add a check to only copy the length of the bitmap to the buffer. The problem can be observed after setting a vcpu affinity using the