Re: [libvirt] [PATCH] Honor blacklist for modprobe command

2014-01-29 Thread Daniel P. Berrange
On Tue, Jan 28, 2014 at 07:00:16PM -0500, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1045124 When loading modules, libvirt does not honor the modprobe blacklist. By adding a -b to the modprobe command libvirt will fail to load a module if it's on the blacklist Check if

Re: [libvirt] [PATCH] Honor blacklist for modprobe command

2014-01-29 Thread John Ferlan
On 01/29/2014 05:40 AM, Daniel P. Berrange wrote: On Tue, Jan 28, 2014 at 07:00:16PM -0500, John Ferlan wrote: This is getting complex enough that I think we ought introduce a src/util/virkmod.{c,h} and have some helper APIs in there for loading and unload modules. eg virKModLoad,

Re: [libvirt] [PATCH] Honor blacklist for modprobe command

2014-01-29 Thread Daniel P. Berrange
On Wed, Jan 29, 2014 at 06:32:42AM -0500, John Ferlan wrote: On 01/29/2014 05:40 AM, Daniel P. Berrange wrote: On Tue, Jan 28, 2014 at 07:00:16PM -0500, John Ferlan wrote: This is getting complex enough that I think we ought introduce a src/util/virkmod.{c,h} and have some helper

[libvirt] [PATCH] Honor blacklist for modprobe command

2014-01-28 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1045124 When loading modules, libvirt does not honor the modprobe blacklist. By adding a -b to the modprobe command libvirt will fail to load a module if it's on the blacklist Check if the failure to load a driver was due to it being on the blacklist