Re: [libvirt] [PATCH] Implement capabilities for Solaris

2009-01-14 Thread Jim Meyering
john.le...@sun.com wrote: ... Hi John, This looks fine, but there are a couple of nits. > +#ifdef __sun > + > +static int > +get_cpu_flags(virConnectPtr conn, const char **hvm, int *pae, int *longmode) > +{ > +struct { > +uint32_t r_eax, r_ebx, r_ecx, r_edx; > +} regs; > + > +

Re: [libvirt] [PATCH] Implement capabilities for Solaris

2009-01-14 Thread John Levon
On Wed, Jan 14, 2009 at 03:38:52PM +, Daniel P. Berrange wrote: > > Implement capabilities for Solaris > > > > Use Solaris interfaces to derive the hypervisor capabilities. > > Previously your patch for this did a hypercall to fetch the > capabilities straight from the hypervisor. Out of int

Re: [libvirt] [PATCH] Implement capabilities for Solaris

2009-01-14 Thread Daniel P. Berrange
On Wed, Jan 14, 2009 at 07:20:12AM -0800, john.le...@sun.com wrote: > # HG changeset patch > # User John Levon > # Date 1231940906 28800 > # Node ID a0d98d39955f4f304d318c7c780742ab929eb351 > # Parent ddfcba6b4181ab433dce345d66dc399a81c92a3b > Implement capabilities for Solaris > > Use Solaris i

[libvirt] [PATCH] Implement capabilities for Solaris

2009-01-14 Thread john . levon
# HG changeset patch # User John Levon # Date 1231940906 28800 # Node ID a0d98d39955f4f304d318c7c780742ab929eb351 # Parent ddfcba6b4181ab433dce345d66dc399a81c92a3b Implement capabilities for Solaris Use Solaris interfaces to derive the hypervisor capabilities. Signed-off-by: John Levon diff -