Re: [libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-14 Thread Laine Stump
On 04/14/2010 06:12 AM, Daniel P. Berrange wrote: This causes it to return a success code in the event of either of the cleanup paths being taken. It needs to be a tri-state return value of -1 (error), 0 (inactive), 1 (active) Ah, yes. I see now that all the vir*Is() functions that have a

Re: [libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-14 Thread Daniel Veillard
On Tue, Apr 13, 2010 at 01:26:00PM -0400, Laine Stump wrote: > Somehow the backend of this function was never implemented in > libvirt's netcf driver, and nobody noticed until now. (The required > netcf function was already in place, so nothing needs to change > there.) > --- > src/interface/netcf

Re: [libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-14 Thread Daniel P. Berrange
On Tue, Apr 13, 2010 at 01:26:00PM -0400, Laine Stump wrote: > Somehow the backend of this function was never implemented in > libvirt's netcf driver, and nobody noticed until now. (The required > netcf function was already in place, so nothing needs to change > there.) > --- > src/interface/netcf

Re: [libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-14 Thread Matthias Bolte
2010/4/13 Laine Stump : > Somehow the backend of this function was never implemented in > libvirt's netcf driver, and nobody noticed until now. (The required > netcf function was already in place, so nothing needs to change > there.) > --- >  src/interface/netcf_driver.c |   31

[libvirt] [PATCH] Implement forgotten backend of virInterfaceIsActive()

2010-04-13 Thread Laine Stump
Somehow the backend of this function was never implemented in libvirt's netcf driver, and nobody noticed until now. (The required netcf function was already in place, so nothing needs to change there.) --- src/interface/netcf_driver.c | 31 ++- 1 files changed, 30 ins