Re: [libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-10 Thread Dave Allan
On 03/09/2010 06:00 PM, Dave Allan wrote: On 03/09/2010 01:55 PM, Eric Blake wrote: On 03/03/2010 03:58 PM, Ed Swierk wrote: The udev node device driver relies on the device symlink in sysfs to populate the node device's parent property. Loopback, vlan and bridge network interfaces don't have

Re: [libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-09 Thread Eric Blake
On 03/03/2010 03:58 PM, Ed Swierk wrote: The udev node device driver relies on the device symlink in sysfs to populate the node device's parent property. Loopback, vlan and bridge network interfaces don't have a real hardware parent but could be useful to include as node devices anyway (and

Re: [libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-09 Thread Ed Swierk
On Tue, Mar 9, 2010 at 10:55 AM, Eric Blake ebl...@redhat.com wrote: Where is udev_device_get_syspath declared?  I'm assuming it's generated, since 'git grep' didn't find it.  The only concern I have is whether it sanely reacts to a NULL argument, but since I couldn't find it, I'm not sure.  

Re: [libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-09 Thread Eric Blake
On 03/09/2010 02:31 PM, Ed Swierk wrote: On Tue, Mar 9, 2010 at 10:55 AM, Eric Blake ebl...@redhat.com wrote: Where is udev_device_get_syspath declared? I'm assuming it's generated, since 'git grep' didn't find it. The only concern I have is whether it sanely reacts to a NULL argument, but

Re: [libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-09 Thread Dave Allan
On 03/09/2010 01:55 PM, Eric Blake wrote: On 03/03/2010 03:58 PM, Ed Swierk wrote: The udev node device driver relies on the device symlink in sysfs to populate the node device's parent property. Loopback, vlan and bridge network interfaces don't have a real hardware parent but could be useful

[libvirt] [PATCH] Include sysfs devices lacking a device symlink as node devices

2010-03-03 Thread Ed Swierk
The udev node device driver relies on the device symlink in sysfs to populate the node device's parent property. Loopback, vlan and bridge network interfaces don't have a real hardware parent but could be useful to include as node devices anyway (and the hal node device driver does include them).