Re: [libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-05 Thread Eric Blake
On 01/04/2011 11:14 PM, Laine Stump wrote: Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't exist). This patch changes that

Re: [libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-05 Thread Laine Stump
On 01/05/2011 11:28 AM, Eric Blake wrote: On 01/04/2011 11:14 PM, Laine Stump wrote: Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't

[libvirt] [PATCH] Log an error on attempts to add a NAT rule for non-IPv4 addresses

2011-01-04 Thread Laine Stump
Although the upper-layer code protected against it, it was possible to call iptablesForwardMasquerade() with an IPv6 address and have it attempt to add a rule to the MASQUERADE chain of ip6tables (which doesn't exist). This patch changes that function to check the protocol of the given address,