Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-11-03 Thread Doug Goldstein
On Sat, Nov 2, 2013 at 4:06 PM, Ryan Schmidt wrote: > On Nov 2, 2013, at 11:01, Ryota Ozaki wrote: > >> I tested this patch on FreeBSD 9.2, Mac OS X 0.7.4 and 10.8.5. >> It worked on all of them. > > Further data points: I successfully built libvirt 1.1.3 with this patch (in > MacPorts) on Mac OS

Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-11-02 Thread Ryan Schmidt
On Nov 2, 2013, at 11:01, Ryota Ozaki wrote: > I tested this patch on FreeBSD 9.2, Mac OS X 0.7.4 and 10.8.5. > It worked on all of them. Further data points: I successfully built libvirt 1.1.3 with this patch (in MacPorts) on Mac OS X 10.5.8 (on both an Intel Mac and a PowerPC Mac). libvirt do

Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-11-02 Thread Ryota Ozaki
On Wed, Oct 30, 2013 at 1:30 PM, Doug Goldstein wrote: > On Tue, Oct 29, 2013 at 6:28 PM, Eric Blake wrote: >> On 10/28/2013 12:05 PM, Doug Goldstein wrote: >>> With Mac OS X 10.9, xdrproc_t is no longer defined as: >>> >>> typedef bool_t (*xdrproc_t) (XDR *, void *, ...); >>> >>> but instead as

Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-10-29 Thread Doug Goldstein
On Tue, Oct 29, 2013 at 6:28 PM, Eric Blake wrote: > On 10/28/2013 12:05 PM, Doug Goldstein wrote: >> With Mac OS X 10.9, xdrproc_t is no longer defined as: >> >> typedef bool_t (*xdrproc_t) (XDR *, void *, ...); >> >> but instead as >> >> typedef bool-t (*xdrproc_t) (XDR *, void *, unsigned int);

Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-10-29 Thread Eric Blake
On 10/28/2013 12:05 PM, Doug Goldstein wrote: > With Mac OS X 10.9, xdrproc_t is no longer defined as: > > typedef bool_t (*xdrproc_t) (XDR *, void *, ...); > > but instead as > > typedef bool-t (*xdrproc_t) (XDR *, void *, unsigned int); > > The rationale explained in the header is that using

Re: [libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-10-28 Thread Doug Goldstein
On Mon, Oct 28, 2013 at 1:05 PM, Doug Goldstein wrote: > With Mac OS X 10.9, xdrproc_t is no longer defined as: > > typedef bool_t (*xdrproc_t) (XDR *, void *, ...); This was the typedef from Linux accidentally so I've updated that as well. > > but instead as > > typedef bool-t (*xdrproc_t) (XDR

[libvirt] [PATCH] MacOS: Handle changes to args in xdrproc_t

2013-10-28 Thread Doug Goldstein
With Mac OS X 10.9, xdrproc_t is no longer defined as: typedef bool_t (*xdrproc_t) (XDR *, void *, ...); but instead as typedef bool-t (*xdrproc_t) (XDR *, void *, unsigned int); The rationale explained in the header is that using a vararg is incorrect and has a potential to change the ABI slig