Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

2016-02-23 Thread Martin Kletzander
On Tue, Feb 23, 2016 at 12:52:38PM +0100, Ján Tomko wrote: On Mon, Feb 22, 2016 at 11:29:54AM +0100, Martin Kletzander wrote: Checking whether x > 0 before looping over [0..x] items doesn't make sense and multi-line body must have curly brackets around it. Please don't mix cosmetic and

Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

2016-02-23 Thread Ján Tomko
On Mon, Feb 22, 2016 at 11:29:54AM +0100, Martin Kletzander wrote: > Checking whether x > 0 before looping over [0..x] items doesn't make > sense and multi-line body must have curly brackets around it. Please don't mix cosmetic and functional changes. Jan > Best viewed with '-w'. > >

Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

2016-02-22 Thread Martin Kletzander
On Mon, Feb 22, 2016 at 12:15:14PM +0100, Michal Privoznik wrote: On 22.02.2016 11:29, Martin Kletzander wrote: Checking whether x > 0 before looping over [0..x] items doesn't make sense and multi-line body must have curly brackets around it. Best viewed with '-w'. Signed-off-by: Martin

Re: [libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

2016-02-22 Thread Michal Privoznik
On 22.02.2016 11:29, Martin Kletzander wrote: > Checking whether x > 0 before looping over [0..x] items doesn't make > sense and multi-line body must have curly brackets around it. > > Best viewed with '-w'. > > Signed-off-by: Martin Kletzander > --- >

[libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

2016-02-22 Thread Martin Kletzander
Checking whether x > 0 before looping over [0..x] items doesn't make sense and multi-line body must have curly brackets around it. Best viewed with '-w'. Signed-off-by: Martin Kletzander --- src/conf/domain_conf.c| 24 +---