Re: [libvirt] [PATCH] More coverity findings addressed

2012-04-27 Thread Laine Stump
On 04/27/2012 03:17 PM, Eric Blake wrote: > On 04/27/2012 12:34 PM, Stefan Berger wrote: >> One note about the error in commandtest line 809: setsid() seems to fail >> when running the test -- could be removed ? > Odd. I think we had to add it to make the test pass under some > situations, so I do

Re: [libvirt] [PATCH] More coverity findings addressed

2012-04-27 Thread Stefan Berger
On 04/27/2012 03:17 PM, Eric Blake wrote: On 04/27/2012 12:34 PM, Stefan Berger wrote: More bug extermination in the category of: Error: CHECKED_RETURN: Maybe worth logging a warning if we see the failure, but since this is test code, I'm also okay if we just ignore it (as long as the test

Re: [libvirt] [PATCH] More coverity findings addressed

2012-04-27 Thread Eric Blake
On 04/27/2012 12:34 PM, Stefan Berger wrote: > More bug extermination in the category of: > > Error: CHECKED_RETURN: > > > One note about the error in commandtest line 809: setsid() seems to fail > when running the test -- could be removed ? Odd. I think we had to add it to make the test pass

[libvirt] [PATCH] More coverity findings addressed

2012-04-27 Thread Stefan Berger
More bug extermination in the category of: Error: CHECKED_RETURN: /libvirt/src/conf/network_conf.c:595: check_return: Calling function "virAsprintf" without checking return value (as is done elsewhere 515 out of 543 times). /libvirt/src/qemu/qemu_process.c:2780: unchecked_value: No check of t