Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Jean-Baptiste Rouault : > On Friday 27 May 2011 16:01:32 Matthias Bolte wrote: >> Thanks, pushed then. >> >> There are other usages of getline in the OpenVZ driver, but they >> should all be safe because they don't distinguish between 0 and -1, >> except openvzGetProcessInfo. >> >> Jean-B

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
On Friday 27 May 2011 16:01:32 Matthias Bolte wrote: > Thanks, pushed then. > > There are other usages of getline in the OpenVZ driver, but they > should all be safe because they don't distinguish between 0 and -1, > except openvzGetProcessInfo. > > Jean-Baptiste could you test virsh dominfo of a

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Daniel Veillard : > On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote: >> On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: >> >> > We need distinguish between getline returning -1 because of EOF and >> > because of another error. I missed this problem in the other

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Daniel Veillard
On Fri, May 27, 2011 at 03:12:26PM +0200, Jean-Baptiste Rouault wrote: > On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: > > > We need distinguish between getline returning -1 because of EOF and > > because of another error. I missed this problem in the other > > regression fix and posted a f

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
On Friday 27 May 2011 13:51:05 Matthias Bolte wrote: > We need distinguish between getline returning -1 because of EOF and > because of another error. I missed this problem in the other > regression fix and posted a follow up patch [1] for this. > > I propose the attached patch as v2 for you patc

Re: [libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Matthias Bolte
2011/5/27 Jean-Baptiste Rouault : > openvzGetUUID did not work since openvz_readline() > was replaced by getline() > --- >  src/openvz/openvz_conf.c |   13 ++--- >  1 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c > index

[libvirt] [PATCH] OpenVZ driver: fix openvzGetVPSUUID()

2011-05-27 Thread Jean-Baptiste Rouault
openvzGetUUID did not work since openvz_readline() was replaced by getline() --- src/openvz/openvz_conf.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 2cccd81..7b939b2 100644 --- a/src/openvz/openvz_