Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-29 Thread Daniel P. Berrange
On Mon, Jul 28, 2008 at 10:12:49AM -0400, Daniel Veillard wrote: On Mon, Jul 28, 2008 at 05:38:47PM +0400, Evgeniy Sokolov wrote: On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: In general that looks way cleaner to me, I will give it a few nmore days and apply, unless

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-29 Thread Daniel Veillard
On Tue, Jul 29, 2008 at 08:53:27AM +0100, Daniel P. Berrange wrote: On Mon, Jul 28, 2008 at 10:12:49AM -0400, Daniel Veillard wrote: On Mon, Jul 28, 2008 at 05:38:47PM +0400, Evgeniy Sokolov wrote: On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: In general that

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-28 Thread Evgeniy Sokolov
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: Patch switch OpenVZ XML format to generic. main changes: - I used generic virDomainNetDef to define network in container. And wrote function to apply virDomainNetDef for container. Method virDomainNetDefParseXML is public

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-28 Thread Daniel Veillard
On Mon, Jul 28, 2008 at 05:38:47PM +0400, Evgeniy Sokolov wrote: On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: In general that looks way cleaner to me, I will give it a few nmore days and apply, unless you suggest another version, fixed patch is attached. Okay, I

[libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Evgeniy Sokolov
Patch switch OpenVZ XML format to generic. main changes: - I used generic virDomainNetDef to define network in container. And wrote function to apply virDomainNetDef for container. Method virDomainNetDefParseXML is public now. - tag container is changed to devices - changed format of tag

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Daniel Veillard
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: Patch switch OpenVZ XML format to generic. main changes: - I used generic virDomainNetDef to define network in container. And wrote function to apply virDomainNetDef for container. Method virDomainNetDefParseXML is public

Re: [libvirt] [PATCH] OpenVZ xml refactoring

2008-07-25 Thread Daniel P. Berrange
On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote: Patch switch OpenVZ XML format to generic. main changes: - I used generic virDomainNetDef to define network in container. And wrote function to apply virDomainNetDef for container. Method virDomainNetDefParseXML is public