Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-11-15 Thread Eric Blake
On 10/29/2010 05:52 AM, Daniel P. Berrange wrote: The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do virDomainLookupByUUID twice in a row, you'll get the same exact virDomainPtr instance. Dave already

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-11-11 Thread Daniel P. Berrange
On Fri, Oct 29, 2010 at 12:52:18PM +0100, Daniel P. Berrange wrote: The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do virDomainLookupByUUID twice in a row, you'll get the same exact virDomainPtr

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-11-11 Thread Dave Allan
On Thu, Nov 11, 2010 at 04:20:43PM +, Daniel P. Berrange wrote: On Fri, Oct 29, 2010 at 12:52:18PM +0100, Daniel P. Berrange wrote: The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-11-11 Thread Daniel P. Berrange
On Thu, Nov 11, 2010 at 11:44:42AM -0500, Dave Allan wrote: On Thu, Nov 11, 2010 at 04:20:43PM +, Daniel P. Berrange wrote: On Fri, Oct 29, 2010 at 12:52:18PM +0100, Daniel P. Berrange wrote: The virConnectPtr struct will cache instances of all other objects. APIs like

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-11-11 Thread Dave Allan
On Thu, Nov 11, 2010 at 04:55:03PM +, Daniel P. Berrange wrote: On Thu, Nov 11, 2010 at 11:44:42AM -0500, Dave Allan wrote: On Thu, Nov 11, 2010 at 04:20:43PM +, Daniel P. Berrange wrote: On Fri, Oct 29, 2010 at 12:52:18PM +0100, Daniel P. Berrange wrote: The virConnectPtr struct

[libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-10-29 Thread Daniel P. Berrange
The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do virDomainLookupByUUID twice in a row, you'll get the same exact virDomainPtr instance. This does not have any performance benefit, since the actual logic

Re: [libvirt] [PATCH] RFC: Remove all object hashtable caches from virConnectPtr

2010-10-29 Thread Daniel P. Berrange
On Fri, Oct 29, 2010 at 12:52:18PM +0100, Daniel P. Berrange wrote: The virConnectPtr struct will cache instances of all other objects. APIs like virDomainLookupByUUID will return a cached object, so if you do virDomainLookupByUUID twice in a row, you'll get the same exact virDomainPtr