Re: [libvirt] [PATCH] Recognize available media in nodedev hal driver

2009-03-02 Thread Jim Meyering
Cole Robinson wrote: The host device hal driver can't tell when a storage device has media available, the culprit being an incorrect return value check. The attached patch fixes this. Unfortunately the driver also doesn't properly detect media eject and media inserted hal events. I've been

Re: [libvirt] [PATCH] Recognize available media in nodedev hal driver

2009-03-02 Thread Daniel P. Berrange
On Fri, Feb 27, 2009 at 11:12:12AM -0500, Cole Robinson wrote: The host device hal driver can't tell when a storage device has media available, the culprit being an incorrect return value check. The attached patch fixes this. Unfortunately the driver also doesn't properly detect media eject

Re: [libvirt] [PATCH] Recognize available media in nodedev hal driver

2009-03-02 Thread Cole Robinson
Cole Robinson wrote: The host device hal driver can't tell when a storage device has media available, the culprit being an incorrect return value check. The attached patch fixes this. Committed now. Thanks, Cole -- Libvir-list mailing list Libvir-list@redhat.com

[libvirt] [PATCH] Recognize available media in nodedev hal driver

2009-02-27 Thread Cole Robinson
The host device hal driver can't tell when a storage device has media available, the culprit being an incorrect return value check. The attached patch fixes this. Unfortunately the driver also doesn't properly detect media eject and media inserted hal events. I've been poking at this but it's a