Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-30 Thread chenfan
On Mon, 2013-07-29 at 17:48 +0100, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state

[libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state between 'running' and 'shutoff' which is only used by the Xen

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Eric Blake
On 07/29/2013 10:48 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient state between

Re: [libvirt] [PATCH] Remove VIR_DOMAIN_SHUTDOWN_CRASHED from public API

2013-07-29 Thread Jiri Denemark
On Mon, Jul 29, 2013 at 17:48:15 +0100, Daniel Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The VIR_DOMAIN_SHUTDOWN_CRASHED state constant does not appear to be used in the QEMU code anyway. It also doesn't make much (any) sense, since the 'shutdown' state is a transient