[libvirt] [PATCH] Report more correct information for cache control

2017-06-05 Thread Martin Kletzander
On some platforms the number of bits in the cbm_mask might not be divisible by 4 (and not even by 2), so we need to properly count the bits. Similar file, min_cbm_bits, is properly parsed and used, but if the number is greater than one, we lose the information about granularity when reporting the

Re: [libvirt] [PATCH] Report more correct information for cache control

2017-06-05 Thread Eli Qiao
hi Martin The code looks good to me, I have 1 comment for the granularity’s comment, and another one for the test data. Otherwise, looks perfect, good to learn how to deal with hex On Monday, 5 June 2017 at 9:14 PM, Martin Kletzander wrote: > On some platforms the number of bits in the c

Re: [libvirt] [PATCH] Report more correct information for cache control

2017-06-06 Thread Martin Kletzander
On Tue, Jun 06, 2017 at 11:58:49AM +0800, Eli Qiao wrote: hi Martin The code looks good to me, I have 1 comment for the granularity’s comment, and another one for the test data. Otherwise, looks perfect, good to learn how to deal with hex I just copied that from virhostcpu.c [...] creat