Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-12-14 Thread Cole Robinson
On 12/14/2013 01:36 PM, Daniel P. Berrange wrote: On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface code is returning a -1 on errors for the `baselineCPU' API. Since this API is supposed to

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Martin Kletzander
On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface code is returning a -1 on errors for the `baselineCPU' API. Since this API is supposed to return a pointer the error return value

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Daniel P. Berrange
On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface code is returning a -1 on errors for the `baselineCPU' API. Since this API is supposed to return a pointer the error return value

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface code is returning a -1 on errors for the `baselineCPU' API.

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: On Sun, Nov 24, 2013 at 10:46:13AM -0600, Doug Goldstein wrote: On Sat, Nov 23, 2013 at 3:15

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Eric Blake
On 11/25/2013 08:55 AM, Don Dugger wrote: I'm basing this on code inspection so I could be wrong but if you look at the Python interface code for libvirt_virDomainSetSchedulerParameters it checks the return value from virDomainSetSchedulerParameters and, if it is 0, then the Pythong code

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Daniel P. Berrange
On Mon, Nov 25, 2013 at 08:55:12AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at 10:45:38AM +, Daniel P. Berrange wrote: On Sun, Nov 24, 2013 at

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-25 Thread Don Dugger
On Mon, Nov 25, 2013 at 04:02:37PM +, Daniel P. Berrange wrote: On Mon, Nov 25, 2013 at 08:55:12AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at 03:48:45PM +, Daniel P. Berrange wrote: On Mon, Nov 25, 2013 at 08:40:41AM -0700, Don Dugger wrote: On Mon, Nov 25, 2013 at

Re: [libvirt] [PATCH] Return right error code for baselineCPU

2013-11-24 Thread Doug Goldstein
On Sat, Nov 23, 2013 at 3:15 PM, Don Dugger n0...@n0ano.com wrote: This Python interface code is returning a -1 on errors for the `baselineCPU' API. Since this API is supposed to return a pointer the error return value should really be VIR_PY_NONE. NB: I've checked all the other APIs in

[libvirt] [PATCH] Return right error code for baselineCPU

2013-11-23 Thread Don Dugger
This Python interface code is returning a -1 on errors for the `baselineCPU' API. Since this API is supposed to return a pointer the error return value should really be VIR_PY_NONE. NB: I've checked all the other APIs in this file and this is the only pointer API that is returning -1.