Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

2011-09-21 Thread Daniel P. Berrange
On Tue, Sep 20, 2011 at 06:00:55PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 20, 2011 at 06:20:48PM +0200, Michal Privoznik wrote: > > This partially reverts commit 984840a2c292402926ad100aeea33f8859ff31a9. > > > > Without this patch, client don't finish a stream which makes any > > API invol

Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

2011-09-20 Thread Dave Allan
On Tue, Sep 20, 2011 at 06:00:55PM +0100, Daniel P. Berrange wrote: > On Tue, Sep 20, 2011 at 06:20:48PM +0200, Michal Privoznik wrote: > > This partially reverts commit 984840a2c292402926ad100aeea33f8859ff31a9. > > > > Without this patch, client don't finish a stream which makes any > > API invol

Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

2011-09-20 Thread Eric Blake
On 09/20/2011 11:00 AM, Daniel P. Berrange wrote: The problem is that with doing virStreamRecv(), we will put a fake call on the queue. We only want to signal completion of those fake calls. This fake call should have been set to have status VIR_NET_CONTINUE but we forgot that. So I think we need

Re: [libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

2011-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2011 at 06:20:48PM +0200, Michal Privoznik wrote: > This partially reverts commit 984840a2c292402926ad100aeea33f8859ff31a9. > > Without this patch, client don't finish a stream which makes any > API involving virStream block indefinitely. > --- > src/rpc/virnetclient.c |5

[libvirt] [PATCH] Revert "Ensure async packets never get marked for sync replies"

2011-09-20 Thread Michal Privoznik
This partially reverts commit 984840a2c292402926ad100aeea33f8859ff31a9. Without this patch, client don't finish a stream which makes any API involving virStream block indefinitely. --- src/rpc/virnetclient.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/rpc/virn