Re: [libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Cole Robinson
On 02/25/2016 09:10 AM, Ján Tomko wrote: > On Thu, Feb 25, 2016 at 08:58:23AM -0500, Cole Robinson wrote: >> On 02/25/2016 08:50 AM, Ján Tomko wrote: >>> On Thu, Feb 25, 2016 at 07:45:17AM -0500, Cole Robinson wrote: On 02/25/2016 07:24 AM, Ján Tomko wrote: > Revert commit

Re: [libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Ján Tomko
On Thu, Feb 25, 2016 at 08:58:23AM -0500, Cole Robinson wrote: > On 02/25/2016 08:50 AM, Ján Tomko wrote: > > On Thu, Feb 25, 2016 at 07:45:17AM -0500, Cole Robinson wrote: > >> On 02/25/2016 07:24 AM, Ján Tomko wrote: > >>> Revert commit 55e6d8cd9eac7eb2aaa4d221585e9402cf7269d5. > >>> > >>> It

Re: [libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Cole Robinson
On 02/25/2016 08:50 AM, Ján Tomko wrote: > On Thu, Feb 25, 2016 at 07:45:17AM -0500, Cole Robinson wrote: >> On 02/25/2016 07:24 AM, Ján Tomko wrote: >>> Revert commit 55e6d8cd9eac7eb2aaa4d221585e9402cf7269d5. >>> >>> It unconditionally required a machine type for all machine types >>> even though

Re: [libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Ján Tomko
On Thu, Feb 25, 2016 at 07:45:17AM -0500, Cole Robinson wrote: > On 02/25/2016 07:24 AM, Ján Tomko wrote: > > Revert commit 55e6d8cd9eac7eb2aaa4d221585e9402cf7269d5. > > > > It unconditionally required a machine type for all machine types > > even though qemu is the only emulator using them. > >

Re: [libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Cole Robinson
On 02/25/2016 07:24 AM, Ján Tomko wrote: > Revert commit 55e6d8cd9eac7eb2aaa4d221585e9402cf7269d5. > > It unconditionally required a machine type for all machine types > even though qemu is the only emulator using them. > > Reverting this re-introduces the crash when someone fiddles with >

[libvirt] [PATCH] Revert "Error out on missing machine type in machine configs"

2016-02-25 Thread Ján Tomko
Revert commit 55e6d8cd9eac7eb2aaa4d221585e9402cf7269d5. It unconditionally required a machine type for all machine types even though qemu is the only emulator using them. Reverting this re-introduces the crash when someone fiddles with libvirt's machine configs with /etc/, but fixes persistent