Re: [libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

On 07/17/2017 08:44 AM, Pavel Hrdina wrote: > On Mon, Jul 17, 2017 at 07:39:28AM -0400, John Ferlan wrote: >> >> >> On 07/17/2017 04:15 AM, Pavel Hrdina wrote: >>> On Sat, Jul 15, 2017 at 02:40:06PM -0400, John Ferlan wrote: This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0.

Re: [libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

On Mon, Jul 17, 2017 at 07:39:28AM -0400, John Ferlan wrote: > > > On 07/17/2017 04:15 AM, Pavel Hrdina wrote: > > On Sat, Jul 15, 2017 at 02:40:06PM -0400, John Ferlan wrote: > >> This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0. > >> > >> As it turns out this ends up very badly as

Re: [libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

On 07/17/2017 04:15 AM, Pavel Hrdina wrote: > On Sat, Jul 15, 2017 at 02:40:06PM -0400, John Ferlan wrote: >> This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0. >> >> As it turns out this ends up very badly as the @def could be Free'd >> even though it's owned by @obj as a result of

Re: [libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

On Sat, Jul 15, 2017 at 02:40:06PM -0400, John Ferlan wrote: > This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0. > > As it turns out this ends up very badly as the @def could be Free'd > even though it's owned by @obj as a result of the AssignDef. I don't see a reason to revert it.

[libvirt] [PATCH] Revert "nwfilter: Move save of config until after successful assign"

This reverts commit b3e71a8830b2683ee88fa10cb048eabb99a446c0. As it turns out this ends up very badly as the @def could be Free'd even though it's owned by @obj as a result of the AssignDef. Signed-off-by: John Ferlan --- src/conf/virnwfilterobj.c | 6 +++--- 1 file