Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-12 Thread Peter Krempa
On Mon, Aug 12, 2019 at 14:15:22 -0400, Stefan Berger wrote: > On 8/12/19 2:11 PM, Peter Krempa wrote: > > On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote: > > > On 8/9/19 6:15 AM, Ján Tomko wrote: > > > > Redefining a domain via virDomainDefineXML should not give different > > > >

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-12 Thread Stefan Berger
On 8/12/19 2:11 PM, Peter Krempa wrote: On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote: On 8/9/19 6:15 AM, Ján Tomko wrote: Redefining a domain via virDomainDefineXML should not give different results based on an already existing definition. I added this patch so that users

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-12 Thread Peter Krempa
On Mon, Aug 12, 2019 at 13:57:40 -0400, Stefan Berger wrote: > On 8/9/19 6:15 AM, Ján Tomko wrote: > > Redefining a domain via virDomainDefineXML should not give different results > > based on an already existing definition. > > > I added this patch so that users don't try to change a VM from

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-12 Thread Stefan Berger
On 8/9/19 6:15 AM, Ján Tomko wrote: Redefining a domain via virDomainDefineXML should not give different results based on an already existing definition. I added this patch so that users don't try to change a VM from encrypted to unencrypted on the level of the domain XML and assume it will

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-09 Thread Marc-André Lureau
Hi On Fri, Aug 9, 2019 at 2:15 PM Ján Tomko wrote: > > Redefining a domain via virDomainDefineXML should not give different results > based on an already existing definition. > > Also, there's a crasher somewhere in the code: > https://bugzilla.redhat.com/show_bug.cgi?id=1739338 > > This reverts

Re: [libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-09 Thread Jiri Denemark
On Fri, Aug 09, 2019 at 12:15:43 +0200, Ján Tomko wrote: > Redefining a domain via virDomainDefineXML should not give different results > based on an already existing definition. > > Also, there's a crasher somewhere in the code: > https://bugzilla.redhat.com/show_bug.cgi?id=1739338 > > This

[libvirt] [PATCH] Revert "tpm: Check TPM XML device configuration changes after edit"

2019-08-09 Thread Ján Tomko
Redefining a domain via virDomainDefineXML should not give different results based on an already existing definition. Also, there's a crasher somewhere in the code: https://bugzilla.redhat.com/show_bug.cgi?id=1739338 This reverts commit 94b3aa55f83ada33a9fdda66068d58ef1a56c0a5 ---