Re: [libvirt] [PATCH] S390: Re-enable capability probing for virtio devices.

2012-12-21 Thread Eric Blake
On 12/21/2012 05:36 AM, Viktor Mihajlovski wrote: > On 12/21/2012 10:57 AM, Daniel P. Berrange wrote: >> >> ACK, sorry about causing that regression. >> >> >> Daniel >> > never mind, the new structure is so much cleaner now. > Would you also be so kind to push the patch (if not done already)? Done

Re: [libvirt] [PATCH] S390: Re-enable capability probing for virtio devices.

2012-12-21 Thread Viktor Mihajlovski
On 12/21/2012 10:57 AM, Daniel P. Berrange wrote: ACK, sorry about causing that regression. Daniel never mind, the new structure is so much cleaner now. Would you also be so kind to push the patch (if not done already)? Thanks and a Happy New Year to All! (Or Happy Doomsday, if preferred ;-)

Re: [libvirt] [PATCH] S390: Re-enable capability probing for virtio devices.

2012-12-21 Thread Daniel P. Berrange
On Fri, Dec 21, 2012 at 10:16:12AM +0100, Viktor Mihajlovski wrote: > Since we switched to QMP probing, the object types are spelled out > explicitly, i.e. virtio-net-pci. This has effectively disabled > the capability detection of s390 virtio devices. The trivial fix > is to add the s390 virtio ty

[libvirt] [PATCH] S390: Re-enable capability probing for virtio devices.

2012-12-21 Thread Viktor Mihajlovski
Since we switched to QMP probing, the object types are spelled out explicitly, i.e. virtio-net-pci. This has effectively disabled the capability detection of s390 virtio devices. The trivial fix is to add the s390 virtio types explicitly to qemuCapsObjectProps. Signed-off-by: Viktor Mihajlovski -