Re: [libvirt] [PATCH] Sanitize qemu monitor output

2008-12-11 Thread Daniel P. Berrange
On Thu, Dec 11, 2008 at 10:13:05AM -0500, Cole Robinson wrote: > Cole Robinson wrote: > Just want to bump this. I'd like to commit this if there are no > objections. Opps, I thought you already had comitted it ! ACK from me. > diff --git a/src/qemu_driver.c b/src/qemu_driver.c > index 0130d61..0

Re: [libvirt] [PATCH] Sanitize qemu monitor output

2008-12-11 Thread Jim Meyering
Cole Robinson <[EMAIL PROTECTED]> wrote: ... >> Updated patch attached. It also fixes an error check from the blockstats >> monitor command which wouldn't have worked in the first place, but >> should be accurate now. >> > > Just want to bump this. I'd like to commit this if there are no > objectio

Re: [libvirt] [PATCH] Sanitize qemu monitor output

2008-12-11 Thread Cole Robinson
Cole Robinson wrote: > Daniel P. Berrange wrote: >> On Mon, Dec 01, 2008 at 05:36:34PM -0500, Cole Robinson wrote: >>> The attached patch cleans up output we read from the qemu monitor. This >>> is a simplified form of a patch I posted awhile ago. From the patch: >>> >>> /* The monitor doesn't dump

Re: [libvirt] [PATCH] Sanitize qemu monitor output

2008-12-02 Thread Cole Robinson
Daniel P. Berrange wrote: > On Mon, Dec 01, 2008 at 05:36:34PM -0500, Cole Robinson wrote: >> The attached patch cleans up output we read from the qemu monitor. This >> is a simplified form of a patch I posted awhile ago. From the patch: >> >> /* The monitor doesn't dump clean output after we have

Re: [libvirt] [PATCH] Sanitize qemu monitor output

2008-12-02 Thread Daniel P. Berrange
On Mon, Dec 01, 2008 at 05:36:34PM -0500, Cole Robinson wrote: > The attached patch cleans up output we read from the qemu monitor. This > is a simplified form of a patch I posted awhile ago. From the patch: > > /* The monitor doesn't dump clean output after we have written to > * it. Every chara

[libvirt] [PATCH] Sanitize qemu monitor output

2008-12-01 Thread Cole Robinson
The attached patch cleans up output we read from the qemu monitor. This is a simplified form of a patch I posted awhile ago. From the patch: /* The monitor doesn't dump clean output after we have written to * it. Every character we write dumps a bunch of useless stuff, * so the result looks like