Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-16 Thread Oved Ourfalli
: libvir-list@redhat.com Sent: Tuesday, May 15, 2012 6:22:13 PM Subject: Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers On Mon, May 14, 2012 at 03:47:57PM -0600, Eric Blake wrote: On 05/14/2012 06:24 AM, Daniel P. Berrange wrote: From: Daniel

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Oved Ourfalli
15, 2012 8:41:32 AM Subject: Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers Hey, I built libvirt RPM with this fix (and the previous addresses fix), and I get the following error when running a VM with USB support: internal error Process

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Daniel P. Berrange
On Tue, May 15, 2012 at 01:41:32AM -0400, Oved Ourfalli wrote: Hey, I built libvirt RPM with this fix (and the previous addresses fix), and I get the following error when running a VM with USB support: internal error Process exited while reading console log output: qemu-kvm: -device

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Daniel P. Berrange
On Tue, May 15, 2012 at 05:25:23AM -0400, Oved Ourfalli wrote: -device piix3-usb-uhci,id=usb,bus=pci.0,addr=0x1.0x2 -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x4.0x7 -device ich9-usb-uhci1,masterbus=usb.0,firstport=0,bus=pci.0,multifunction=on,addr=0x4 -device

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Oved Ourfalli
You're right. I used an old VM and it didn't work well (VM from early dev phase for this feature). I created a new one. First time I run it, it works. The second time, in which we pass the address (as we store it in the ovirt engine database), I get the following XML: controller

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Daniel P. Berrange
On Tue, May 15, 2012 at 07:22:52AM -0400, Oved Ourfalli wrote: You're right. I used an old VM and it didn't work well (VM from early dev phase for this feature). I created a new one. First time I run it, it works. The second time, in which we pass the address (as we store it in the ovirt

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-15 Thread Daniel P. Berrange
On Mon, May 14, 2012 at 03:47:57PM -0600, Eric Blake wrote: On 05/14/2012 06:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The uhci1, uhci2, uhci3 companion controllers for ehci1 must have a master start port set. Since this value is predictable we

[libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com The uhci1, uhci2, uhci3 companion controllers for ehci1 must have a master start port set. Since this value is predictable we should set it automatically if the app does not supply it --- src/conf/domain_conf.c | 22

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Eric Blake
On 05/14/2012 06:24 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com The uhci1, uhci2, uhci3 companion controllers for ehci1 must have a master start port set. Since this value is predictable we should set it automatically if the app does not supply it ---

Re: [libvirt] [PATCH] Set a sensible default master start port for ehci companion controllers

2012-05-14 Thread Oved Ourfalli
Hey, I built libvirt RPM with this fix (and the previous addresses fix), and I get the following error when running a VM with USB support: internal error Process exited while reading console log output: qemu-kvm: -device ich9-usb-ehci1,id=usb,bus=pci.0,addr=0x4.0x7: Duplicate ID 'usb' for