Re: [libvirt] [PATCH] Strict check when listing domains

2010/6/2 Eduardo Otubo ot...@linux.vnet.ibm.com: Now sending patches using format-patch and send-email, pretty interesting! This is the final version, fixing the style according to the new HACKING file. ---  src/phyp/phyp_driver.c |   34 ++  1 files changed,

Re: [libvirt] [PATCH] Strict check when listing domains

Sorry for the late review... diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 4f7efdb..eb6be32 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1849,41 +1849,32 @@ phypUUIDTable_Init(virConnectPtr conn) { uuid_tablePtr uuid_table;

[libvirt] [PATCH] Strict check when listing domains

Now sending patches using format-patch and send-email, pretty interesting! This is the final version, fixing the style according to the new HACKING file. --- src/phyp/phyp_driver.c | 34 ++ 1 files changed, 14 insertions(+), 20 deletions(-) diff --git

Re: [libvirt] [PATCH] Strict check when listing domains

2010/3/30 Eduardo Otubo ot...@linux.vnet.ibm.com: I am really sorry. I sent an older version of the patch, here is the correct one. Eric Blake wrote: On 03/24/2010 11:19 AM, Eduardo Otubo wrote:     /* exit early if there are no domains */ -    if (nids == 0) +    if (nids_numdomains

Re: [libvirt] [PATCH] Strict check when listing domains

I am really sorry. I sent an older version of the patch, here is the correct one. Eric Blake wrote: On 03/24/2010 11:19 AM, Eduardo Otubo wrote: /* exit early if there are no domains */ -if (nids == 0) +if (nids_numdomains == 0 || nids_listdomains == 0 +||

Re: [libvirt] [PATCH] Strict check when listing domains

On 03/24/2010 11:19 AM, Eduardo Otubo wrote: /* exit early if there are no domains */ -if (nids == 0) +if (nids_numdomains == 0 || nids_listdomains == 0 +|| nids_numdomains != nids_listdomains) return 0; Should we be reporting an error here... -if

[libvirt] [PATCH] Strict check when listing domains

-- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems Technology Group Mobile: +55 19 8135 0885 eot...@linux.vnet.ibm.com diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index e4d67dc..f9a36a1 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@