[libvirt] [PATCH] Support QEMU/KVM watchdog device

2009-10-21 Thread Richard W.M. Jones
Time to brush off this old patch. This adds simple support for the QEMU/KVM emulated hardware watchdog device (qemu commit 9dd986ccf68f142aaafe543d80cf877716d91d4e). Event notification isn't supported. This just lets you configure a domain with a watchdog.../ device, select the model and

Re: [libvirt] [PATCH] Support QEMU/KVM watchdog device

2009-10-21 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 01:32:49PM +0100, Richard W.M. Jones wrote: Time to brush off this old patch. This adds simple support for the QEMU/KVM emulated hardware watchdog device (qemu commit 9dd986ccf68f142aaafe543d80cf877716d91d4e). Event notification isn't supported. This just lets you

Re: [libvirt] [PATCH] Support QEMU/KVM watchdog device

2009-10-21 Thread Richard W.M. Jones
On Wed, Oct 21, 2009 at 04:42:06PM +0200, Daniel Veillard wrote: On Wed, Oct 21, 2009 at 01:32:49PM +0100, Richard W.M. Jones wrote: +if ((n = virXPathNodeSet(conn, ./devices/watchdog, ctxt, nodes)) 0) { +virDomainReportError(conn, VIR_ERR_INTERNAL_ERROR, +

Re: [libvirt] [PATCH] Support QEMU/KVM watchdog device

2009-10-21 Thread Daniel Veillard
On Wed, Oct 21, 2009 at 03:52:18PM +0100, Richard W.M. Jones wrote: On Wed, Oct 21, 2009 at 04:42:06PM +0200, Daniel Veillard wrote: On Wed, Oct 21, 2009 at 01:32:49PM +0100, Richard W.M. Jones wrote: +if ((n = virXPathNodeSet(conn, ./devices/watchdog, ctxt, nodes)) 0) { +

Re: [libvirt] [PATCH] Support QEMU/KVM watchdog device

2009-10-21 Thread Richard W.M. Jones
On Wed, Oct 21, 2009 at 05:28:49PM +0200, Daniel Veillard wrote: okay but indentation seems funky, can you double check ? Tabs/spaces thing. I'll fix it up before pushing. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of