Re: [libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

2010-03-03 Thread Daniel Veillard
On Wed, Feb 24, 2010 at 03:58:09PM -0500, Laine Stump wrote: > (This version incorporates the suggestions from Jim Meyering and Eric Blake) > > If qemudDomainRestore fails to open the domain save file, create a > pipe, then fork a process that does setuid(qemu_user) and opens the > file, then read

Re: [libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

2010-02-25 Thread Eric Blake
According to Laine Stump on 2/25/2010 3:19 PM: > Thanks once again for the informative review! (I've learned something > new about git, which isn't really surprising I supposed, since I > currently know so little ;-)) One of the things I love about open source is that everyone learns from each oth

Re: [libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

2010-02-25 Thread Laine Stump
Thanks once again for the informative review! (I've learned something new about git, which isn't really surprising I supposed, since I currently know so little ;-)) On 02/25/2010 12:34 PM, Eric Blake wrote: According to Laine Stump on 2/24/2010 1:58 PM: (This version incorporates the sugg

Re: [libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

2010-02-25 Thread Eric Blake
According to Laine Stump on 2/24/2010 1:58 PM: > (This version incorporates the suggestions from Jim Meyering and Eric Blake) I guess that line is okay to leave in the commit message. If it had been me, though, I would have left it out of the commit log, and just inserted it between the --- and d

[libvirt] [PATCH] Take Two - Fix domain restore for files on root-squash NFS.

2010-02-24 Thread Laine Stump
(This version incorporates the suggestions from Jim Meyering and Eric Blake) If qemudDomainRestore fails to open the domain save file, create a pipe, then fork a process that does setuid(qemu_user) and opens the file, then reads this file and stuffs it into the pipe. the parent libvirtd process wi