Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-19 Thread harryxiyou
On Fri, Apr 19, 2013 at 1:42 PM, Osier Yang jy...@redhat.com wrote: [...] There is no new things in the wiki. Sorry, i have not put my new design plan for 'Rename volume name'. Before writing the code, I'd suggest going through the HACKING and the document for how to implement a new API for

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-19 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 09:03:59AM -0600, Eric Blake wrote: On 04/18/2013 06:21 AM, harryxiyou wrote: On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com

[libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna rename a volume name. Signed-off-by: Harry Wei harryxi...@gmail.com --- tools/virsh-volume.c | 103 ++ 1 file changed, 103 insertions(+) diff

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Osier Yang
On 18/04/13 16:29, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna rename a volume name. NACK. It should use the upcoming rename APIs for the *-rename virsh commands instead . Signed-off-by: Harry Wei

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Daniel P. Berrange
On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna rename a volume name. Signed-off-by: Harry Wei harryxi...@gmail.com --- tools/virsh-volume.c | 103

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:27 PM, Osier Yang jy...@redhat.com wrote: On 18/04/13 16:29, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna rename a volume name. NACK. It should use the upcoming rename APIs for the

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna rename a volume name. Signed-off-by: Harry

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Eric Blake
On 04/18/2013 06:21 AM, harryxiyou wrote: On Thu, Apr 18, 2013 at 5:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Thu, Apr 18, 2013 at 04:29:45PM +0800, harryxi...@gmail.com wrote: From: Harry Wei harryxi...@gmail.com Vol-rename is a convenience function, requiring when one wanna

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread harryxiyou
On Thu, Apr 18, 2013 at 11:03 PM, Eric Blake ebl...@redhat.com wrote: [...] Exactly - we need to add a new libvirt API that can support renames at the backend driver level, with instant effect (a directory pool forwarding to rename(2), other pools using pool-specific renaming commands). It

Re: [libvirt] [PATCH] Virsh command vol-rename

2013-04-18 Thread Osier Yang
On 19/04/13 11:35, harryxiyou wrote: On Thu, Apr 18, 2013 at 11:03 PM, Eric Blake ebl...@redhat.com wrote: [...] Exactly - we need to add a new libvirt API that can support renames at the backend driver level, with instant effect (a directory pool forwarding to rename(2), other pools using