Re: [libvirt] [PATCH] Xen Events Updated

2008-11-25 Thread Daniel P. Berrange
On Tue, Nov 25, 2008 at 11:19:04AM +0100, Daniel Veillard wrote: > On Mon, Nov 24, 2008 at 03:44:28PM +, Daniel P. Berrange wrote: > > +++ b/configure.in Mon Nov 24 09:08:01 2008 -0500 > > @@ -147,6 +147,8 @@ dnl Allow to build without Xen, QEMU/KVM > > dnl Allow to build without Xen, QEMU/KV

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-25 Thread Daniel Veillard
On Mon, Nov 24, 2008 at 03:44:28PM +, Daniel P. Berrange wrote: > On Fri, Nov 21, 2008 at 02:11:39PM -0500, Ben Guthro wrote: > > I have integrated your changes, and moved this bit referenced below, > > so it works with my setup. Could you please test with yours, and > > make sure I didn't br

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
I have integrated your changes, and moved this bit referenced below, so it works with my setup. Could you please test with yours, and make sure I didn't break anything? configure.in | 13 examples/domain-events/events-c/event-test.c |2 include/libvirt/virt

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Daniel P. Berrange
On Fri, Nov 21, 2008 at 01:56:16PM -0500, Ben Guthro wrote: > I think I found the culprit of this: > > Daniel P. Berrange wrote on 11/21/2008 11:13 AM: > > - Allocate capabilities info before initializing inotify driver > >because loading XM config files /etc/xen requires this > > > ... > >

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
I think I found the culprit of this: Daniel P. Berrange wrote on 11/21/2008 11:13 AM: > - Allocate capabilities info before initializing inotify driver >because loading XM config files /etc/xen requires this > ... > -if (!(priv->caps = xenHypervisorMakeCapabilities(conn))) { > -D

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Daniel P. Berrange
On Fri, Nov 21, 2008 at 01:06:08PM -0500, Ben Guthro wrote: > I tested these changes, and seem to be having some issues opening the xen > driver in a post 3.0.3 codepath: > > DEBUG: xen_unified.c: xenUnifiedOpen (Trying hypervisor sub-driver) > DEBUG: xen_unified.c: xenUnifiedOpen (Activated hype

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Ben Guthro
I tested these changes, and seem to be having some issues opening the xen driver in a post 3.0.3 codepath: DEBUG: xen_unified.c: xenUnifiedOpen (Trying hypervisor sub-driver) DEBUG: xen_unified.c: xenUnifiedOpen (Activated hypervisor sub-driver) libvir: Xen Daemon error : internal error failed to

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-21 Thread Daniel P. Berrange
On Thu, Nov 20, 2008 at 03:49:07PM -0500, Ben Guthro wrote: > New xen events patch attached. This removes a couple unnecessary > changes from my prior patch, but remains functionally the same as > the last version. > > This will emit the following events for Xen: > > STARTED > STOPPED > ADDED >

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
New xen events patch attached. This removes a couple unnecessary changes from my prior patch, but remains functionally the same as the last version. This will emit the following events for Xen: STARTED STOPPED ADDED REMOVED diff --git a/configure.in b/configure.in index 21931a1..a38592a 100644 -

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-20 Thread Ben Guthro
I see a couple of issues with this patch that I am working out now Apologies for premature submission. (Thats what I get for submitting at the end of the day) New patch to follow shortly Ben Guthro wrote on 11/19/2008 05:47 PM: > I finally was able to get back to this patch. > > Attached is a n

Re: [libvirt] [PATCH] Xen Events Updated

2008-11-12 Thread Daniel P. Berrange
On Tue, Nov 11, 2008 at 01:34:29PM -0500, Ben Guthro wrote: > This version of the Xen-Events patch goes a step further > than the last version, and now emits the following domain events: > > STARTED > STOPPED > ADDED > REMOVED > > This is accomplished by monitoring /etc/xen, and taking advantage

[libvirt] [PATCH] Xen Events Updated

2008-11-11 Thread Ben Guthro
This version of the Xen-Events patch goes a step further than the last version, and now emits the following domain events: STARTED STOPPED ADDED REMOVED This is accomplished by monitoring /etc/xen, and taking advantage of what seemed to be dormant code in the XM driver. By re-enabling the "conf