Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-04-27 Thread Paolo Bonzini
Il 09/04/2014 17:12, Daniel P. Berrange ha scritto: > On Tue, Apr 08, 2014 at 03:06:13PM -0300, Marcelo Tosatti wrote: >> On Mon, Mar 17, 2014 at 09:39:54AM +, Daniel P. Berrange wrote: >>> We recently had a bunch more feature requests around huge page support >>> in libvirt, so I think it is p

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-04-09 Thread Daniel P. Berrange
On Tue, Apr 08, 2014 at 03:06:13PM -0300, Marcelo Tosatti wrote: > On Mon, Mar 17, 2014 at 09:39:54AM +, Daniel P. Berrange wrote: > > We recently had a bunch more feature requests around huge page support > > in libvirt, so I think it is preferrable not to merge this currently. > > We need to

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-04-09 Thread Marcelo Tosatti
On Mon, Mar 17, 2014 at 09:39:54AM +, Daniel P. Berrange wrote: > On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote: > > On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: > > > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > > > > On Tue, Feb 0

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-03-17 Thread Daniel P. Berrange
On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote: > On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: > > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > > > > > Add an

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-03-14 Thread Marcelo Tosatti
On Fri, Mar 14, 2014 at 06:52:19PM -0300, Marcelo Tosatti wrote: > On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: > > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > > > > > Add an

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-03-14 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > > > Add an element named "strict-hugepages" to control whether to > > > refuse guest

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-05 Thread Marcelo Tosatti
On Wed, Feb 05, 2014 at 09:49:53AM +, Daniel P. Berrange wrote: > On Tue, Feb 04, 2014 at 03:04:11PM -0700, Eric Blake wrote: > > On 02/04/2014 02:57 PM, Marcelo Tosatti wrote: > > > > > >> So perhaps we do need some "policy" attribute on the > > >> element to indicate desired behaviour here.

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-05 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 03:04:11PM -0700, Eric Blake wrote: > On 02/04/2014 02:57 PM, Marcelo Tosatti wrote: > > > >> So perhaps we do need some "policy" attribute on the > >> element to indicate desired behaviour here. > > > > What about the following new element under ? > > > > enforce_hugep

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Eric Blake
On 02/04/2014 07:42 PM, Marcelo Tosatti wrote: >> >> >> 1 >> >> >> where strict could be no if we are giving a hint but don't care if the >> hint cannot be honored (default yes if omitted), and where unit + value > > Its awkward because you'd always want the largest hugepages size > possible,

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 03:04:11PM -0700, Eric Blake wrote: > On 02/04/2014 02:57 PM, Marcelo Tosatti wrote: > > > >> So perhaps we do need some "policy" attribute on the > >> element to indicate desired behaviour here. > > > > What about the following new element under ? > > > > enforce_hugep

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Eric Blake
On 02/04/2014 02:57 PM, Marcelo Tosatti wrote: > >> So perhaps we do need some "policy" attribute on the >> element to indicate desired behaviour here. > > What about the following new element under ? > > enforce_hugepage_size=integer Which feels a bit redundant (we're already under the ele

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:26:31PM +, Daniel P. Berrange wrote: > On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: > > > > You're OK with StrictHugePageSize=N element ? > > I'm not entirely sure what that would do ? Is that for when people want > to have a specific size of hug

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:26:31PM +, Daniel P. Berrange wrote: > On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: > > > > You're OK with StrictHugePageSize=N element ? > > I'm not entirely sure what that would do ? Is that for when people want > to have a specific size of hug

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 12:22:00PM -0500, Marcelo Tosatti wrote: > > You're OK with StrictHugePageSize=N element ? I'm not entirely sure what that would do ? Is that for when people want to have a specific size of hugepages ? If so, then I guess we might actually need some kind of granularity her

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 05:10:13PM +, Daniel P. Berrange wrote: > > Because there is no guarantee with -mem-prealloc. For instance, if the > > hugepage path is not actually hugetlbfs backed, QEMU falls back to > > malloc(). > > Well if you can't fix -mem-prealloc to properly report errors for

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
You're OK with StrictHugePageSize=N element ? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 12:18:34PM -0500, Marcelo Tosatti wrote: > On Tue, Feb 04, 2014 at 05:10:13PM +, Daniel P. Berrange wrote: > > > Because there is no guarantee with -mem-prealloc. For instance, if the > > > hugepage path is not actually hugetlbfs backed, QEMU falls back to > > > malloc()

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 11:54:22AM -0500, Marcelo Tosatti wrote: > On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > > > Add an element named "strict-hugepages" to control whether to > > > refuse guest

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > Add an element named "strict-hugepages" to control whether to > > refuse guest initialization in case hugepage allocation cannot > > be performed. > > >

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
On Tue, Feb 04, 2014 at 04:42:02PM +, Daniel P. Berrange wrote: > On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > > > Add an element named "strict-hugepages" to control whether to > > refuse guest initialization in case hugepage allocation cannot > > be performed. > > >

Re: [libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Daniel P. Berrange
On Tue, Feb 04, 2014 at 11:32:47AM -0500, Marcelo Tosatti wrote: > > Add an element named "strict-hugepages" to control whether to > refuse guest initialization in case hugepage allocation cannot > be performed. > > Signed-off-by: Marcelo Tosatti > > diff --git a/docs/formatdomain.html.in b/d

[libvirt] [PATCH] add flag to enforce hugepage backing of guest RAM

2014-02-04 Thread Marcelo Tosatti
Add an element named "strict-hugepages" to control whether to refuse guest initialization in case hugepage allocation cannot be performed. Signed-off-by: Marcelo Tosatti diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index ff50214..e79f5e6 100644 --- a/docs/formatdomain.ht