Re: [libvirt] [PATCH] add sentinel attribute

2009-11-06 Thread Daniel Veillard
On Thu, Nov 05, 2009 at 06:07:54PM +0100, Paolo Bonzini wrote: On 11/05/2009 06:04 PM, Daniel Veillard wrote: +static int ATTRIBUTE_SENTINEL ebtablesAddRemoveRule(ebtRules *rules, int action, const char *arg, ...) { I'm just surprized by having the __attribute__ being inserted

[libvirt] [PATCH] add sentinel attribute

2009-11-04 Thread Paolo Bonzini
This patch adds a (macro-wrapped) sentinel attribute to functions that take a NULL-terminated variable argument list. This is a nice debugging aid. * src/internal.h (ATTRIBUTE_SENTINEL): New. * src/util/buf.c (virBufferStrcat): Use it. * src/util/ebtables.c (ebtablesAddRemoveRule): Use it. *

Re: [libvirt] [PATCH] add sentinel attribute

2009-11-04 Thread Daniel P. Berrange
On Wed, Nov 04, 2009 at 06:49:47PM +0100, Paolo Bonzini wrote: This patch adds a (macro-wrapped) sentinel attribute to functions that take a NULL-terminated variable argument list. This is a nice debugging aid. * src/internal.h (ATTRIBUTE_SENTINEL): New. * src/util/buf.c (virBufferStrcat):