Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

On 01/18/2018 01:46 AM, Charles Kelimod wrote: > Hello John, > This is a technical list - top-posting is not acceptable. > I have questions: > >>>This and the Parse makes no sense when compared to the 3 possible > options.  That is, it's possible to have "tcp", "rdma", and "iser", but > you

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

Hello John, I have questions: >>This and the Parse makes no sense when compared to the 3 possible options. That is, it's possible to have "tcp", "rdma", and "iser", but you only care about "iser". This is because for other types are optional, there was no this line here, therefor I added this

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

On 01/16/2018 03:52 AM, lichs...@gmail.com wrote: > From: zhangshengyu > This needs to be split up better into multiple patches - there are many examples of how to do that. Just see how patches were done the last time someone added a new transport type. Typically

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

From: zhangshengyu --- docs/schemas/domaincommon.rng | 28 + src/conf/domain_conf.c | 8 src/qemu/qemu_block.c | 24 ++- src/qemu/qemu_command.c

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

Hello, I have not got revert back since I sent last patch on 12/22/2017, just want to know how it is going on? Regards, Charles. On Fri, Dec 22, 2017 at 3:08 PM, Charles Kelimod wrote: > Hi Peter, > > I will remove the comment. > I did the test and noticed the issue, then

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

From: zhangshengyu --- docs/schemas/domaincommon.rng | 28 + src/conf/domain_conf.c | 8 src/qemu/qemu_block.c | 24 ++- src/qemu/qemu_command.c

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

Hi Peter, I will remove the comment. I did the test and noticed the issue, then I reverted to a clean workspace which is cloned from the libvirt git datastore, however I meet the same issue when running the test: VIR_TEST_DEBUG=1 VIR_TEST_EXPENSIVE=1 make check Therefor I thought it was something

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

On Thu, Dec 21, 2017 at 16:27:15 +0800, lichs...@gmail.com wrote: > From: zhangshengyu > > --- > src/conf/domain_conf.c | 10 ++ > src/qemu/qemu_block.c | 24 +++-- > src/qemu/qemu_command.c

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

From: zhangshengyu --- src/conf/domain_conf.c | 10 ++ src/qemu/qemu_block.c | 24 +++-- src/qemu/qemu_command.c| 3 ++ src/qemu/qemu_parse_command.c

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

I made clear why it create iscsi+iser, not only that the system have many place expect iscsi+iser type of strings, like qemuParseDriveURIString. but actually for qemu command line, iser://example.org... can work while iscsi+iser will not, how should I do? Currently for json type of command line in

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

Thank you for your patience, I regret for my first time submit here that brings so may mistakes. I have done almost changes that you have mentioned. Now I have a question: I created drive-file-network-args.xml in test, and there is: -drive

Re: [libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

On Thu, Dec 14, 2017 at 18:14:36 +0800, lichs...@gmail.com wrote: > From: zhangshengyu As pointed out last time, please follow the contributor guidelines. You did not run make syntax-check. Also the contributor guidelines state that you should write a commit message.

[libvirt] [PATCH] add support of iSER transport type in qemu with libiscsi

From: zhangshengyu --- src/conf/domain_conf.c | 13 src/qemu/qemu_block.c | 17 +- src/util/virstoragefile.c | 3 +- src/util/virstoragefile.h