[libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-04 Thread Daniel P. Berrange
When autogen.sh finishes it helpfully prints "Now type 'make' to compile libvirt." which is fine if on a host with GNU make, but on *BSD running 'make' will end in tears. We should tell users to run 'gmake' on these platforms. If 'gmake' doesn't exist then we should report an error too "GNU

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-05 Thread Andrea Bolognani
On Tue, 2017-07-04 at 16:22 +0100, Daniel P. Berrange wrote: > When autogen.sh finishes it helpfully prints >  >   "Now type 'make' to compile libvirt." >  > which is fine if on a host with GNU make, but on *BSD running > 'make' will end in tears. We should tell users to run 'gmake' > on these plat

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-05 Thread Eric Blake
On 07/05/2017 11:32 AM, Andrea Bolognani wrote: > On Tue, 2017-07-04 at 16:22 +0100, Daniel P. Berrange wrote: >> When autogen.sh finishes it helpfully prints >> >>"Now type 'make' to compile libvirt." >> >> which is fine if on a host with GNU make, but on *BSD running >> 'make' will end in

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-10 Thread Andrea Bolognani
On Wed, 2017-07-05 at 13:06 -0500, Eric Blake wrote: > > This doesn't catch stderr for the make invocation, and > > FreeBSD's make doesn't support the -v flag so you'll > > end up with a bunch of spurious output. You can use > >  > >   make -v 2>&1 | grep -q "GNU Make" >  > Yes, that is indeed impo

Re: [libvirt] [PATCH] autogen.sh: tell user the correct make command

2017-07-11 Thread Martin Kletzander
On Wed, Jul 05, 2017 at 06:32:07PM +0200, Andrea Bolognani wrote: On Tue, 2017-07-04 at 16:22 +0100, Daniel P. Berrange wrote: When autogen.sh finishes it helpfully prints      "Now type 'make' to compile libvirt."   which is fine if on a host with GNU make, but on *BSD running 'make' will end i