Re: [libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

2015-11-17 Thread Roman Bogorodskiy
Daniel P. Berrange wrote: > On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote: > > Current monitor code overrides domain object's privateData, e.g. > > in virBhyveProcessStart(): > > > > vm->privateData = bhyveMonitorOpen(vm, driver); > > > > where bhyveMonitorPtr() returns

Re: [libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

2015-11-16 Thread Daniel P. Berrange
On Wed, Nov 04, 2015 at 06:08:00PM +0300, Roman Bogorodskiy wrote: > Current monitor code overrides domain object's privateData, e.g. > in virBhyveProcessStart(): > > vm->privateData = bhyveMonitorOpen(vm, driver); > > where bhyveMonitorPtr() returns bhyveMonitorPtr. > > This is not right

Re: [libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

2015-11-12 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: > Current monitor code overrides domain object's privateData, e.g. > in virBhyveProcessStart(): > > vm->privateData = bhyveMonitorOpen(vm, driver); > > where bhyveMonitorPtr() returns bhyveMonitorPtr. > > This is not right thing to do, so make bhyveMonitorPtr > a

Re: [libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

2015-11-09 Thread Roman Bogorodskiy
Roman Bogorodskiy wrote: > Current monitor code overrides domain object's privateData, e.g. > in virBhyveProcessStart(): > > vm->privateData = bhyveMonitorOpen(vm, driver); > > where bhyveMonitorPtr() returns bhyveMonitorPtr. > > This is not right thing to do, so make bhyveMonitorPtr > a

[libvirt] [PATCH] bhyve: monitor: do not override domain's privateData

2015-11-04 Thread Roman Bogorodskiy
Current monitor code overrides domain object's privateData, e.g. in virBhyveProcessStart(): vm->privateData = bhyveMonitorOpen(vm, driver); where bhyveMonitorPtr() returns bhyveMonitorPtr. This is not right thing to do, so make bhyveMonitorPtr a part of the bhyveDomainObjPrivate struct and