[libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Martin Kletzander
Adding dbus_message_unref() into virDBusMessageDecodeArgs() makes sure that the message gets unref'd, thus making one more pure dbus call not necessary. Even though we are calling a lot of dbus_* functions outside virdbus (which should be fixed in the future IMHO), this patch fixes only this one

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Daniel P. Berrange
On Mon, Apr 14, 2014 at 01:41:18PM +0200, Martin Kletzander wrote: Adding dbus_message_unref() into virDBusMessageDecodeArgs() makes sure that the message gets unref'd, thus making one more pure dbus call not necessary. Even though we are calling a lot of dbus_* functions outside virdbus

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Martin Kletzander
On Mon, Apr 14, 2014 at 01:02:02PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 01:41:18PM +0200, Martin Kletzander wrote: Adding dbus_message_unref() into virDBusMessageDecodeArgs() makes sure that the message gets unref'd, thus making one more pure dbus call not necessary. Even

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Daniel P. Berrange
On Mon, Apr 14, 2014 at 02:20:11PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at 01:02:02PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 01:41:18PM +0200, Martin Kletzander wrote: Adding dbus_message_unref() into virDBusMessageDecodeArgs() makes sure that the message gets

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Martin Kletzander
On Mon, Apr 14, 2014 at 01:33:21PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 02:20:11PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at 01:02:02PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 01:41:18PM +0200, Martin Kletzander wrote: Adding

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Daniel P. Berrange
On Mon, Apr 14, 2014 at 02:51:18PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at 01:33:21PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 02:20:11PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at 01:02:02PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at

Re: [libvirt] [PATCH] build: Embed dbus_message_unref in virdbus

2014-04-14 Thread Martin Kletzander
On Mon, Apr 14, 2014 at 02:29:36PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 02:51:18PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at 01:33:21PM +0100, Daniel P. Berrange wrote: On Mon, Apr 14, 2014 at 02:20:11PM +0200, Martin Kletzander wrote: On Mon, Apr 14, 2014 at