Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-19 Thread Jiri Denemark
On Tue, Mar 18, 2014 at 09:44:43 -0600, Eric Blake wrote: On 03/18/2014 09:32 AM, Jiri Denemark wrote: On Tue, Mar 18, 2014 at 06:27:48 -0600, Eric Blake wrote: On 03/18/2014 05:00 AM, Jiri Denemark wrote: Why don't we just avoid the whole issue by removing use of abs_srcdir and

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Jiri Denemark
On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote: On 03/14/2014 12:55 PM, Jiri Denemark wrote: On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote: On 03/14/2014 04:43 AM, Jiri Denemark wrote: Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Daniel P. Berrange
On Tue, Mar 18, 2014 at 11:36:51AM +0100, Jiri Denemark wrote: On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote: On 03/14/2014 12:55 PM, Jiri Denemark wrote: On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote: On 03/14/2014 04:43 AM, Jiri Denemark wrote: Ancient automake

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Jiri Denemark
On Tue, Mar 18, 2014 at 10:42:01 +, Daniel Berrange wrote: On Tue, Mar 18, 2014 at 11:36:51AM +0100, Jiri Denemark wrote: On Mon, Mar 17, 2014 at 09:33:11 -0600, Eric Blake wrote: On 03/14/2014 12:55 PM, Jiri Denemark wrote: On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote:

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Eric Blake
On 03/18/2014 05:00 AM, Jiri Denemark wrote: Why don't we just avoid the whole issue by removing use of abs_srcdir and abs_builddir. Can this rule: $(abs_builddir)/cpu/cpu_map.xml: $(AM_V_GEN)ln -s $(abs_srcdir)/cpu/cpu_map.xml $@ be just changed to cpu/cpu_map.xml:

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Jiri Denemark
On Tue, Mar 18, 2014 at 06:27:48 -0600, Eric Blake wrote: On 03/18/2014 05:00 AM, Jiri Denemark wrote: Why don't we just avoid the whole issue by removing use of abs_srcdir and abs_builddir. Can this rule: $(abs_builddir)/cpu/cpu_map.xml: $(AM_V_GEN)ln -s

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-18 Thread Eric Blake
On 03/18/2014 09:32 AM, Jiri Denemark wrote: On Tue, Mar 18, 2014 at 06:27:48 -0600, Eric Blake wrote: On 03/18/2014 05:00 AM, Jiri Denemark wrote: Why don't we just avoid the whole issue by removing use of abs_srcdir and abs_builddir. Can this rule: $(abs_builddir)/cpu/cpu_map.xml:

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-17 Thread Eric Blake
On 03/14/2014 12:55 PM, Jiri Denemark wrote: On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote: On 03/14/2014 04:43 AM, Jiri Denemark wrote: Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir variables which are used by a recent commit of mine (e562e82).

[libvirt] [PATCH] build: Fix build with old automake

2014-03-14 Thread Jiri Denemark
Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir variables which are used by a recent commit of mine (e562e82). Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/Makefile.am

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-14 Thread Pavel Hrdina
On 14.3.2014 11:43, Jiri Denemark wrote: Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir variables which are used by a recent commit of mine (e562e82). Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/Makefile.am | 4 1 file changed, 4

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-14 Thread Eric Blake
On 03/14/2014 04:43 AM, Jiri Denemark wrote: Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir variables which are used by a recent commit of mine (e562e82). Signed-off-by: Jiri Denemark jdene...@redhat.com --- src/Makefile.am | 4 1 file changed, 4

Re: [libvirt] [PATCH] build: Fix build with old automake

2014-03-14 Thread Jiri Denemark
On Fri, Mar 14, 2014 at 07:54:58 -0600, Eric Blake wrote: On 03/14/2014 04:43 AM, Jiri Denemark wrote: Ancient automake (such as from RHEL5) does not provide abs_srcdir and abs_builddir variables which are used by a recent commit of mine (e562e82). Signed-off-by: Jiri Denemark