Re: [libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Eric Blake
On 07/29/2011 10:07 AM, Matthias Bolte wrote: 2011/7/29 Eric Blake: POSIX states that 'a=1; a=2 b=$a command' has unspecified results for the value of $b visible within command. In particular, on BSD, this resulted in PATH not picking up the in-test ssh. * tests/Makefile.am (lv_abs_top_builddi

Re: [libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Matthias Bolte
2011/7/29 Eric Blake : > POSIX states that 'a=1; a=2 b=$a command' has unspecified results > for the value of $b visible within command.  In particular, on > BSD, this resulted in PATH not picking up the in-test ssh. > > * tests/Makefile.am (lv_abs_top_builddir): New macro. > (path_add, TESTS_ENVIR

[libvirt] [PATCH] build: avoid non-portable shell in test setup

2011-07-29 Thread Eric Blake
POSIX states that 'a=1; a=2 b=$a command' has unspecified results for the value of $b visible within command. In particular, on BSD, this resulted in PATH not picking up the in-test ssh. * tests/Makefile.am (lv_abs_top_builddir): New macro. (path_add, TESTS_ENVIRONMENT): Use it to avoid referring