Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-08-31 Thread Eric Blake
On 08/28/2012 09:17 PM, Doug Goldstein wrote: not part of the commit Really just looking for feedback if this an acceptable update to the previous work. My plan is to add a 'udev' backend that will provide just some basic read-only host interface information. Basically I've been seeing

[libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-08-28 Thread Doug Goldstein
not part of the commit Really just looking for feedback if this an acceptable update to the previous work. My plan is to add a 'udev' backend that will provide just some basic read-only host interface information. Basically I've been seeing postings to libvirt-users and virt-tools where people

Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-07-01 Thread Osier Yang
On 2012年06月30日 00:32, Daniel P. Berrange wrote: On Fri, Jun 29, 2012 at 10:18:47AM -0600, Eric Blake wrote: On 06/29/2012 01:34 AM, Osier Yang wrote: On 2012年06月29日 07:57, Eric Blake wrote: Our code was mistakenly relying on an undefined macro, WITH_INTERFACE, for determining whether to load

Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-06-29 Thread Osier Yang
On 2012年06月29日 07:57, Eric Blake wrote: Our code was mistakenly relying on an undefined macro, WITH_INTERFACE, for determining whether to load the interface driver which wraps the netcf library. Clean this situation up by having only one automake conditional for the driver, and having both

Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-06-29 Thread Eric Blake
On 06/29/2012 01:34 AM, Osier Yang wrote: On 2012年06月29日 07:57, Eric Blake wrote: Our code was mistakenly relying on an undefined macro, WITH_INTERFACE, for determining whether to load the interface driver which wraps the netcf library. Clean this situation up by having only one automake

Re: [libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-06-29 Thread Daniel P. Berrange
On Fri, Jun 29, 2012 at 10:18:47AM -0600, Eric Blake wrote: On 06/29/2012 01:34 AM, Osier Yang wrote: On 2012年06月29日 07:57, Eric Blake wrote: Our code was mistakenly relying on an undefined macro, WITH_INTERFACE, for determining whether to load the interface driver which wraps the netcf

[libvirt] [PATCH] build: define WITH_INTERFACE for the driver

2012-06-28 Thread Eric Blake
Our code was mistakenly relying on an undefined macro, WITH_INTERFACE, for determining whether to load the interface driver which wraps the netcf library. Clean this situation up by having only one automake conditional for the driver, and having both WITH_NETCF (library detected) and