Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Jim Meyering
On Fri, Oct 6, 2017 at 7:47 AM, Eric Blake wrote: > On 10/05/2017 06:07 AM, Pino Toscano wrote: >> The majority of the syntax check is taylored for C sources, so some of >> the checks already cause false positives for non-C sources (and thus >> there are exclusion regexps in place). >> >> Instead,

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Eric Blake
On 10/06/2017 12:07 PM, Jim Meyering wrote: > On Fri, Oct 6, 2017 at 7:47 AM, Eric Blake wrote: >> On 10/05/2017 06:07 AM, Pino Toscano wrote: >>> The majority of the syntax check is taylored for C sources, so some of >>> the checks already cause false positives for non-C sources (and thus >>> the

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Eric Blake
On 10/06/2017 08:23 AM, Michal Privoznik wrote: >>> .spec is not in the repo, so it's never checked. And then, we perhaps >>> want to check .spec.in? For instance for space at EOF. >> >> .spec is generated from .spec.in, so for a builddir==srcdir build, >> syntax-check will find both; hence, IMHO

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Eric Blake
On 10/05/2017 06:07 AM, Pino Toscano wrote: > The majority of the syntax check is taylored for C sources, so some of > the checks already cause false positives for non-C sources (and thus > there are exclusion regexps in place). > > Instead, just exclude more non-C files from all the checks: > - p

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Michal Privoznik
On 10/06/2017 02:56 PM, Pino Toscano wrote: > On Friday, 6 October 2017 12:32:28 CEST Michal Privoznik wrote: >> On 10/05/2017 01:07 PM, Pino Toscano wrote: >>> The majority of the syntax check is taylored for C sources, so some of >>> the checks already cause false positives for non-C sources (and

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Pino Toscano
On Friday, 6 October 2017 12:32:28 CEST Michal Privoznik wrote: > On 10/05/2017 01:07 PM, Pino Toscano wrote: > > The majority of the syntax check is taylored for C sources, so some of > > the checks already cause false positives for non-C sources (and thus > > there are exclusion regexps in place)

Re: [libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-06 Thread Michal Privoznik
On 10/05/2017 01:07 PM, Pino Toscano wrote: > The majority of the syntax check is taylored for C sources, so some of > the checks already cause false positives for non-C sources (and thus > there are exclusion regexps in place). > > Instead, just exclude more non-C files from all the checks: > - p

[libvirt] [PATCH] build: exclude more files from all the syntax checks

2017-10-05 Thread Pino Toscano
The majority of the syntax check is taylored for C sources, so some of the checks already cause false positives for non-C sources (and thus there are exclusion regexps in place). Instead, just exclude more non-C files from all the checks: - pot files: they are templates for po files (already exclu