Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-06-12 Thread Andrea Bolognani
On Tue, 2019-06-04 at 09:33 +0200, Andrea Bolognani wrote: > I have something almost reasonable in a local branch, I'll polish it > up in the next few days and then post it. Done :) https://www.redhat.com/archives/libvir-list/2019-June/msg00339.html -- Andrea Bolognani / Red Hat /

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-06-04 Thread Andrea Bolognani
On Mon, 2019-06-03 at 15:41 -0600, Jim Fehlig wrote: > On 5/30/19 10:00 AM, Andrea Bolognani wrote: > > Actually I'd go one further and adopt what Xen tests are doing: > > there's an explicit > > > >libxl_LDADDS += $(LDADDS) > > > > and then most tests include at least $(libxl_LDADDS) in

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-06-03 Thread Jim Fehlig
On 5/30/19 10:00 AM, Andrea Bolognani wrote: On Thu, 2019-05-30 at 16:56 +0200, Michal Privoznik wrote: On 5/30/19 4:44 PM, Jim Fehlig wrote: On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: -libqemutestdriver_la_LIBADD = $(qemu_LDADDS)

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Andrea Bolognani
On Thu, 2019-05-30 at 16:56 +0200, Michal Privoznik wrote: > On 5/30/19 4:44 PM, Jim Fehlig wrote: > > On 5/30/19 3:08 AM, Michal Privoznik wrote: > > > On 5/29/19 7:44 PM, Jim Fehlig wrote: > > > > -libqemutestdriver_la_LIBADD = $(qemu_LDADDS) > > > > +libqemutestdriver_la_LIBADD = $(qemu_LDADDS)

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Jim Fehlig
On 5/30/19 8:56 AM, Michal Privoznik wrote: On 5/30/19 4:44 PM, Jim Fehlig wrote: On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Michal Privoznik
On 5/30/19 4:44 PM, Jim Fehlig wrote: On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared  -fPIC

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Jim Fehlig
On 5/30/19 3:08 AM, Michal Privoznik wrote: On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared  -fPIC -DPIC  ../src/libvirt_qemu_probes.o  \

Re: [libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-30 Thread Michal Privoznik
On 5/29/19 7:44 PM, Jim Fehlig wrote: openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared -fPIC -DPIC ../src/libvirt_qemu_probes.o \ -Wl,--whole-archive

[libvirt] [PATCH] build: fix linking libqemutestdriver with LTO enabled

2019-05-29 Thread Jim Fehlig
openSUSE Factory is in the process of enabling Link Time Optimization [0] and stumbled upon missing symbols when linking libqemutestdriver libtool: link: gcc -shared -fPIC -DPIC ../src/libvirt_qemu_probes.o \ -Wl,--whole-archive ../src/.libs/libvirt_driver_qemu_impl.a \