Re: [libvirt] [PATCH] build: restore support for libyajl 2.0.1

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 04:10:36PM +0200, Olaf Hering wrote: > Am Thu, 9 May 2019 13:31:45 +0200 > schrieb Ján Tomko : > > > +dnl TODO: delete this in July 2020 > > Does this come with a cost? I mean, SLE_12 is not going away any time soon. > Just dropping things because we can seems to be

Re: [libvirt] [PATCH] build: restore support for libyajl 2.0.1

2019-05-09 Thread Olaf Hering
Am Thu, 9 May 2019 13:31:45 +0200 schrieb Ján Tomko : > +dnl TODO: delete this in July 2020 Does this come with a cost? I mean, SLE_12 is not going away any time soon. Just dropping things because we can seems to be the wrong approach. There might be other new things that must be used in

Re: [libvirt] [PATCH] build: restore support for libyajl 2.0.1

2019-05-09 Thread Andrea Bolognani
On Thu, 2019-05-09 at 13:31 +0200, Ján Tomko wrote: > + PKG_CHECK_EXISTS([readline], [use_pkgconfig=1], [use_pkgconfig=0]) > + > + if test $use_pkgconfig = 1; then > +dnl 2.0.3 was the version where the pkg-config file was first added > +LIBVIRT_CHECK_PKG([YAJL], [yajl], [2.0.3]) > +

[libvirt] [PATCH] build: restore support for libyajl 2.0.1

2019-05-09 Thread Ján Tomko
Commit 105756660f944e7db02de3b55b98bb7c11cd03bf was too eager and did not consider SLE 12 which still has 2.0.1 that does not ship a pkg-config file. Similar to how we check for readline, prefer pkg-config if available and fall back to the old detection code if not found. NB: this is not a clean