Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-04-09 Thread Cole Robinson
On 04/08/2016 12:27 PM, Andrea Bolognani wrote: > On Mon, 2016-02-29 at 15:41 +0100, Martin Kletzander wrote: >> On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: >>> >>> gcc 6.0 added an annoying warning: >>> >>> fdstream.c: In function 'virFDStreamWrite': >>> fdstream.c:390:29:

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-04-08 Thread Andrea Bolognani
On Mon, 2016-02-29 at 15:41 +0100, Martin Kletzander wrote: > On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: > >  > > gcc 6.0 added an annoying warning: > >  > > fdstream.c: In function 'virFDStreamWrite': > > fdstream.c:390:29: error: logical 'or' of equal expressions > >

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-29 Thread Martin Kletzander
On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: gcc 6.0 added an annoying warning: fdstream.c: In function 'virFDStreamWrite': fdstream.c:390:29: error: logical 'or' of equal expressions [-Werror=logical-op] if (errno == EAGAIN || errno == EWOULDBLOCK) {

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Peter Krempa
On Thu, Feb 25, 2016 at 14:52:16 +0100, Ján Tomko wrote: > On Thu, Feb 25, 2016 at 06:46:55AM -0700, Eric Blake wrote: > > D'oh. I blame emacs - I have it set to remind me to automatically update > > copyright, and must have accidentally said yes to updating the diff. > > I'll need to teach my

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Michal Privoznik
On 25.02.2016 14:48, Eric Blake wrote: > On 02/25/2016 04:15 AM, Pavel Hrdina wrote: >> On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: >>> gcc 6.0 added an annoying warning: >>> >>> fdstream.c: In function 'virFDStreamWrite': >>> fdstream.c:390:29: error: logical 'or' of equal

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Ján Tomko
On Thu, Feb 25, 2016 at 06:46:55AM -0700, Eric Blake wrote: > On 02/25/2016 02:37 AM, Peter Krempa wrote: > > On Thu, Feb 25, 2016 at 09:52:12 +0100, Andrea Bolognani wrote: > >> On Thu, 2016-02-25 at 09:22 +0100, Michal Privoznik wrote: > >>> I'm having some difficulties applying this: > >>> > >

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Eric Blake
On 02/25/2016 04:15 AM, Pavel Hrdina wrote: > On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: >> gcc 6.0 added an annoying warning: >> >> fdstream.c: In function 'virFDStreamWrite': >> fdstream.c:390:29: error: logical 'or' of equal expressions >> [-Werror=logical-op] >> if

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Eric Blake
On 02/25/2016 02:37 AM, Peter Krempa wrote: > On Thu, Feb 25, 2016 at 09:52:12 +0100, Andrea Bolognani wrote: >> On Thu, 2016-02-25 at 09:22 +0100, Michal Privoznik wrote: >>> I'm having some difficulties applying this: >>> > > Well, simply the patch context is broken in the first hunk: > > The

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Pavel Hrdina
On Wed, Feb 24, 2016 at 02:29:58PM -0700, Eric Blake wrote: > gcc 6.0 added an annoying warning: > > fdstream.c: In function 'virFDStreamWrite': > fdstream.c:390:29: error: logical 'or' of equal expressions > [-Werror=logical-op] > if (errno == EAGAIN || errno == EWOULDBLOCK) { >

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Peter Krempa
On Thu, Feb 25, 2016 at 09:52:12 +0100, Andrea Bolognani wrote: > On Thu, 2016-02-25 at 09:22 +0100, Michal Privoznik wrote: > > I'm having some difficulties applying this: > > > > > > Applying: build: work around gcc 6.0 warnings > > Using index info to reconstruct a base tree... > > error:

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Andrea Bolognani
On Thu, 2016-02-25 at 09:22 +0100, Michal Privoznik wrote: > I'm having some difficulties applying this: > > > Applying: build: work around gcc 6.0 warnings > Using index info to reconstruct a base tree... > error: patch failed: src/fdstream.c:1 > error: src/fdstream.c: patch does not apply >

Re: [libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-25 Thread Michal Privoznik
On 24.02.2016 22:29, Eric Blake wrote: > gcc 6.0 added an annoying warning: > > fdstream.c: In function 'virFDStreamWrite': > fdstream.c:390:29: error: logical 'or' of equal expressions > [-Werror=logical-op] > if (errno == EAGAIN || errno == EWOULDBLOCK) { >

[libvirt] [PATCH] build: work around gcc 6.0 warnings

2016-02-24 Thread Eric Blake
gcc 6.0 added an annoying warning: fdstream.c: In function 'virFDStreamWrite': fdstream.c:390:29: error: logical 'or' of equal expressions [-Werror=logical-op] if (errno == EAGAIN || errno == EWOULDBLOCK) { ^~ fdstream.c: In function 'virFDStreamRead':