Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-16 Thread Laine Stump
On 02/15/2011 07:33 PM, Eric Blake wrote: On 02/15/2011 05:01 PM, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- rc =

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-16 Thread Eric Blake
On 02/15/2011 08:34 PM, Daniel Veillard wrote: On Tue, Feb 15, 2011 at 05:01:18PM -0700, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. ---

[libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-15 Thread Eric Blake
* src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- src/util/cgroup.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-15 Thread Eric Blake
On 02/15/2011 05:01 PM, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- rc = virFileWriteStr(keypath, value, 0); if (rc 0) { -

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-15 Thread Daniel Veillard
On Tue, Feb 15, 2011 at 05:01:18PM -0700, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. --- src/util/cgroup.c | 12 ++-- 1 files

Re: [libvirt] [PATCH] cgroup: preserve correct errno on failure

2011-02-15 Thread Daniel Veillard
On Tue, Feb 15, 2011 at 05:33:09PM -0700, Eric Blake wrote: On 02/15/2011 05:01 PM, Eric Blake wrote: * src/util/cgroup.c (virCgroupSetValueStr, virCgroupGetValueStr) (virCgroupRemoveRecursively): VIR_DEBUG can clobber errno. (virCgroupRemove): Use VIR_DEBUG rather than DEBUG. ---