Re: [libvirt] [PATCH] command: enforce fd vs. buffer considerations

2010-12-07 Thread Matthias Bolte
2010/12/7 Eric Blake ebl...@redhat.com: * docs/internals/command.html.in: Better documentation of buffer vs. fd considerations. * src/util/command.c (virCommandRunAsync): Reject raw execution with string io. (virCommandRun): Reject execution with user-specified fds not visiting a regular

Re: [libvirt] [PATCH] command: enforce fd vs. buffer considerations

2010-12-07 Thread Eric Blake
On 12/07/2010 02:59 PM, Matthias Bolte wrote: 2010/12/7 Eric Blake ebl...@redhat.com: * docs/internals/command.html.in: Better documentation of buffer vs. fd considerations. * src/util/command.c (virCommandRunAsync): Reject raw execution with string io. (virCommandRun): Reject execution with

[libvirt] [PATCH] command: enforce fd vs. buffer considerations

2010-12-06 Thread Eric Blake
* docs/internals/command.html.in: Better documentation of buffer vs. fd considerations. * src/util/command.c (virCommandRunAsync): Reject raw execution with string io. (virCommandRun): Reject execution with user-specified fds not visiting a regular file. --- Perhaps we need to relax the fstat