Re: [libvirt] [PATCH] conf: Check for attach disk usage of iothread=0

2015-08-20 Thread Martin Kletzander
On Wed, Aug 12, 2015 at 05:27:48PM -0400, John Ferlan wrote: Since iothreadid = 0 is invalid, we need to check for it when attempting to add a disk; otherwise, someone would think/believe their attempt to add an IOThread to the disk would succeed. Luckily other code ignored things when -iothread

Re: [libvirt] [PATCH] conf: Check for attach disk usage of iothread=0

2015-08-18 Thread John Ferlan
On 08/12/2015 05:27 PM, John Ferlan wrote: Since iothreadid = 0 is invalid, we need to check for it when attempting to add a disk; otherwise, someone would think/believe their attempt to add an IOThread to the disk would succeed. Luckily other code ignored things when -iothread == 0...

[libvirt] [PATCH] conf: Check for attach disk usage of iothread=0

2015-08-12 Thread John Ferlan
Since iothreadid = 0 is invalid, we need to check for it when attempting to add a disk; otherwise, someone would think/believe their attempt to add an IOThread to the disk would succeed. Luckily other code ignored things when -iothread == 0... Signed-off-by: John Ferlan jfer...@redhat.com ---