Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-24 Thread Andrea Bolognani
On Mon, 2017-07-24 at 10:32 +0200, Peter Krempa wrote: > Please send a fixed version of this patch that will make sure that it > states that the PHB thing is a pSeries thing, so that it does not > confuse others as it did me. Done :) --  Andrea Bolognani / Red Hat / Virtualization -- libvir-list

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-24 Thread Peter Krempa
On Fri, Jul 21, 2017 at 10:39:05 +0200, Andrea Bolognani wrote: > On Fri, 2017-07-21 at 10:07 +0200, Andrea Bolognani wrote: [...] > > That makes sense. > >  > > Doesn't it also mean that we don't really need to record > > whether the user set the model name explicitly or not? We > > can just ski

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-21 Thread Andrea Bolognani
On Fri, 2017-07-21 at 10:07 +0200, Andrea Bolognani wrote: > > That is the main reason to fill all the values in right away. Since > > there apparently was a period, where a default would be used, but not > > recorded, it needs some trickery unfortunately. > >   > > In such case you basically stand

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-21 Thread Andrea Bolognani
On Thu, 2017-07-20 at 09:55 +0200, Peter Krempa wrote: > > In any case, that made me realize that not sending the model, > > even if automatically filled in, could cause issues in the > > future if a new model is added and becomes the default, as > > the guest ABI would not be preserved during migr

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-20 Thread Peter Krempa
On Wed, Jul 19, 2017 at 16:41:54 +0200, Andrea Bolognani wrote: > On Wed, 2017-07-19 at 15:33 +0200, Peter Krempa wrote: > > > Recent commits made it so that pci-root controllers for > >  > > Did we release this? > > Nope, it will be in the next release. > > > > +/* Don't format the model

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-19 Thread Andrea Bolognani
On Wed, 2017-07-19 at 15:33 +0200, Peter Krempa wrote: > > Recent commits made it so that pci-root controllers for >  > Did we release this? Nope, it will be in the next release. > > +/* Don't format the model name for PHBs when migrating so that > > + * guests that only use the d

Re: [libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-19 Thread Peter Krempa
On Wed, Jul 19, 2017 at 14:10:27 +0200, Andrea Bolognani wrote: > Recent commits made it so that pci-root controllers for Did we release this? > pSeries guests are automatically assigned the > spapr-pci-host-bridge model name; however, that prevents > guests to migrate to older versions of libvir

[libvirt] [PATCH] conf: Fix backwards migration of pSeries guests

2017-07-19 Thread Andrea Bolognani
Recent commits made it so that pci-root controllers for pSeries guests are automatically assigned the spapr-pci-host-bridge model name; however, that prevents guests to migrate to older versions of libvirt which don't know about that model name at all, which at the moment is all of them :) To avoi