Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:44:20 -0400, John Ferlan wrote: On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. ---

[libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. --- Pushed as trivial. src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread John Ferlan
On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. --- Pushed as trivial. src/conf/domain_conf.c | 2 +- 1 file

Re: [libvirt] [PATCH] conf: Fix invalid pointer check in virDomainObjGetDefs

2015-06-04 Thread Peter Krempa
On Thu, Jun 04, 2015 at 07:44:20 -0400, John Ferlan wrote: On 06/04/2015 07:28 AM, Peter Krempa wrote: Coverity rightfully determined that in commit 3d021381c71221e563182f03 I made a mistake in the first check if @persDef is not NULL is dereferencing it rather than checking. ---