Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-28 Thread Han Han
On Thu, Oct 18, 2018 at 5:28 PM Martin Kletzander wrote: > On Thu, Oct 18, 2018 at 02:12:36PM +0800, Han Han wrote: > >On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander > >wrote: > > > >> On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > >> > > >> > > >> >On 10/14/18 10:26 AM, Han H

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-18 Thread Martin Kletzander
On Thu, Oct 18, 2018 at 02:12:36PM +0800, Han Han wrote: On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander wrote: On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > > >On 10/14/18 10:26 AM, Han Han wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1535930 >> >> Report more clea

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-17 Thread Han Han
On Wed, Oct 17, 2018 at 4:46 PM Martin Kletzander wrote: > On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: > > > > > >On 10/14/18 10:26 AM, Han Han wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=1535930 > >> > >> Report more clear err msg instead of unknown error when coales

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-17 Thread Martin Kletzander
On Tue, Oct 16, 2018 at 07:19:41PM -0400, John Ferlan wrote: On 10/14/18 10:26 AM, Han Han wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Incomplete is not an error. It's request for remov

Re: [libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-16 Thread John Ferlan
On 10/14/18 10:26 AM, Han Han wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1535930 > > Report more clear err msg instead of unknown error when coalesce > settings is incomplete. > > Signed-off-by: Han Han > --- > src/conf/domain_conf.c | 6 +- > 1 file changed, 5 insertions(+), 1

[libvirt] [PATCH] conf: More clear error msg for incomplete coalesce xml

2018-10-14 Thread Han Han
https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Report more clear err msg instead of unknown error when coalesce settings is incomplete. Signed-off-by: Han Han --- src/conf/domain_conf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/co