Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Peter Krempa
On 08/03/12 18:40, Eric Blake wrote: On 08/03/2012 03:27 AM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was s/a open/an open/ wrong as it tried to remove the callback also when

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Eric Blake
On 08/03/2012 03:27 AM, Peter Krempa wrote: > Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of > the daemon when a domain with a open console was destroyed. The fix was s/a open/an open/ > wrong as it tried to remove the callback also when the stream was > aborted, where at t

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Peter Krempa
On 08/03/12 11:56, Alex Jia wrote: On 08/03/2012 05:27 PM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted,

Re: [libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Alex Jia
On 08/03/2012 05:27 PM, Peter Krempa wrote: Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd stream dr

[libvirt] [PATCH] conf: Remove console stream callback only when freeing console helper

2012-08-03 Thread Peter Krempa
Commit ba226d334acbc49f6751b430e0c4e00f69eef6bf tried to fix crash of the daemon when a domain with a open console was destroyed. The fix was wrong as it tried to remove the callback also when the stream was aborted, where at that point the fd stream driver was already freed and removed. This patc