Re: [libvirt] [PATCH] conf: fix bogus error when is in an

2018-09-07 Thread Laine Stump
On 09/07/2018 06:41 AM, Ján Tomko wrote: > conf: fix boot order with > > You don't need the whole reproducer in the commit summary But what you've given isn't a correct description :-) The boot order isn't being fixed; the false error is being eliminated. > > On Thu, Sep 06, 2018 at 09:14:26PM

Re: [libvirt] [PATCH] conf: fix bogus error when is in an

2018-09-07 Thread Ján Tomko
conf: fix boot order with You don't need the whole reproducer in the commit summary On Thu, Sep 06, 2018 at 09:14:26PM -0400, Laine Stump wrote: virDomainDefCollectBootOrder() is called for every item on the list for each type of device. Since an is on both the list of hostdev devices and

[libvirt] [PATCH] conf: fix bogus error when is in an

2018-09-06 Thread Laine Stump
virDomainDefCollectBootOrder() is called for every item on the list for each type of device. Since an is on both the list of hostdev devices and the list of network devices, it will be counted twice, and the code that checks for multiple devices with the same boot order will give a false